BUG: Avoid copying uninitialized pixels in VectorIterationBenchmark#109
Open
N-Dekker wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
Collaborator
N-Dekker
commented
Dec 10, 2025
N-Dekker
commented
- Following ITK pull request BUG: Avoid copying uninitialized pixels in CastImageFilter ITK#5680
Following ITK pull request InsightSoftwareConsortium/ITK#5680 "BUG: Avoid copying uninitialized pixels in CastImageFilter"
N-Dekker
commented
Dec 10, 2025
Comment on lines
+104
to
+119
| if constexpr (isVariableLengthVector<OutputPixelType>) | ||
| { | ||
| value[k] = static_cast<typename OutputPixelType::ValueType>(inputPixel[k]); | ||
| OutputPixelType value(outputIt.Get()); | ||
| for (unsigned int k = 0; k < componentsPerPixel; ++k) | ||
| { | ||
| value[k] = static_cast<typename OutputPixelType::ValueType>(inputPixel[k]); | ||
| } | ||
| } | ||
| else | ||
| { | ||
| OutputPixelType value; | ||
| for (unsigned int k = 0; k < componentsPerPixel; ++k) | ||
| { | ||
| value[k] = static_cast<typename OutputPixelType::ValueType>(inputPixel[k]); | ||
| } | ||
| outputIt.Set(value); |
Collaborator
Author
There was a problem hiding this comment.
Note that the VariableLengthVector case just calls outputIt.Get(), whereas the regular Vector/FixedArray case just calls outputIt.Set(value), with this PR!
thewtex
approved these changes
Dec 10, 2025
| OutputPixelType value(outputIt.Get()); | ||
| for (unsigned int k = 0; k < componentsPerPixel; ++k) | ||
|
|
||
| if constexpr (isVariableLengthVector<OutputPixelType>) |
Member
|
Thank you for applying the bug fix here too. I was hoping to see the performance difference with the change, compare to the the original loop. Please merge if you are done with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.